RFR: 8243961: ForceNUMA and only one available NUMA node fails assertion on Windows

stefan.johansson at oracle.com stefan.johansson at oracle.com
Tue May 5 08:53:09 UTC 2020



On 2020-05-02 11:59, Kim Barrett wrote:
> 
> New webrev:
> https://cr.openjdk.java.net/~kbarrett/8243961/open.01/
Looks good. Just one small thing and I know people have different 
opinions about this, so ignore this if you like. NUMA isn't supported on 
AIX, so I think it would make more sense to use FLAG_SET_DEFAULT there.

No need for a re-review,
Stefan

> 
> (No incremental; the code change to os_windows.cpp is the same, but
> the rationale and commentary are entirely different.)
> 
> Testing:
> mach5 tier1-3, normally, with -XX:+UseNUMA -XX:+ForceNUMA added.
> 
> TestUseNUMAInterleaving still fails on Windows with +UseNUMA
> +ForceNUMA on a single-node machine, because +UseNUMAInterleaving gets
> turned off, which is not what the test expects.
> 
> Manually verified that on Linux -XX:+UseNUMAInterleaving alone gets
> overridden off when libnuma_init is patched to fail.
> 
> 


More information about the hotspot-gc-dev mailing list