RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (hotspot)

Mikael Vidstedt mikael.vidstedt at oracle.com
Thu May 7 05:19:07 UTC 2020



> On May 4, 2020, at 2:11 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
> 
> Hi,
> 
> On 04.05.20 10:28, Stefan Karlsson wrote:
>> Hi Mikael,
>> On 2020-05-04 07:12, Mikael Vidstedt wrote:
>>> 
>>> Please review this change which implements part of JEP 381:
>>> 
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8244224
>>> webrev: http://cr.openjdk.java.net/~mikael/webrevs/8244224/webrev.00/hotspot/open/webrev/ 
>> I went over this patch and collected some comments:
>> src/hotspot/share/adlc/output_c.cpp
>> src/hotspot/share/adlc/output_h.cpp
>> Awkward code layout after change to.
>> src/hotspot/share/c1/c1_Runtime1.cpp
>> src/hotspot/share/classfile/classListParser.cpp
>> src/hotspot/share/memory/arena.hpp
>> src/hotspot/share/opto/chaitin.cpp
>> test/hotspot/jtreg/gc/TestCardTablePageCommits.jav >
> > Surrounding comments still refers to Sparc and/or Solaris.
> >
> > There are even more places if you search in the rest of the HotSpot
> > source. Are we leaving those for a separate cleanup pass?
> 
> In addition to "sparc", "solaris", also "solstudio"/"Sun Studio"/"SS compiler bug"/"niagara" yield some search (=grep) results.
> 
> Some of these locations look like additional RFEs.

Ah good! I found and fixed a few additional places based on those strings, but would like to handling the remaining comment updates as RFEs.

Thank you for having a look!

Cheers,
Mikael



More information about the hotspot-gc-dev mailing list