RFR (XS) 8244730: Shenandoah: gc/shenandoah/options/TestHeuristicsUnlock.java should only verify the heuristics

Aleksey Shipilev shade at redhat.com
Mon May 11 12:02:05 UTC 2020


RFE:
  https://bugs.openjdk.java.net/browse/JDK-8244730

gc/shenandoah/options/TestHeuristicsUnlock.java implicitly verifies the unlocking of IU or Passive
mode. This is unnecessary, as we have /gc/shenandoah/options/TestModeUnlock.java, which does it
explicitly. Current code works, because it has disabled some checks until Shenandoah is
non-experimental. But it would break soon. We better off removing mode checks from this test.

Fix:

diff -r 158e145e3a42 test/hotspot/jtreg/gc/shenandoah/options/TestHeuristicsUnlock.java
--- a/test/hotspot/jtreg/gc/shenandoah/options/TestHeuristicsUnlock.java        Sat May 09 13:42:16
2020 -0700
+++ b/test/hotspot/jtreg/gc/shenandoah/options/TestHeuristicsUnlock.java        Mon May 11 14:00:27
2020 +0200
@@ -46,12 +46,8 @@

     public static void main(String[] args) throws Exception {
-        testWith("-XX:ShenandoahGCHeuristics=adaptive", Mode.PRODUCT);
-        testWith("-XX:ShenandoahGCHeuristics=static", Mode.PRODUCT);
-        testWith("-XX:ShenandoahGCHeuristics=compact", Mode.PRODUCT);
-
-        testWith("-XX:ShenandoahGCMode=iu", Mode.EXPERIMENTAL);
-
+        testWith("-XX:ShenandoahGCHeuristics=adaptive",   Mode.PRODUCT);
+        testWith("-XX:ShenandoahGCHeuristics=static",     Mode.PRODUCT);
+        testWith("-XX:ShenandoahGCHeuristics=compact",    Mode.PRODUCT);
         testWith("-XX:ShenandoahGCHeuristics=aggressive", Mode.DIAGNOSTIC);
-        testWith("-XX:ShenandoahGCHeuristics=passive", Mode.DIAGNOSTIC);
     }

Testing: hotspot_gc_shenandoah

-- 
Thanks,
-Aleksey



More information about the hotspot-gc-dev mailing list