RFR(S) 8244775 Remove unnecessary dependency to jfrEvents.hpp

Ioi Lam ioi.lam at oracle.com
Wed May 13 15:31:13 UTC 2020



On 5/13/20 1:50 AM, Kim Barrett wrote:
>> On May 12, 2020, at 1:36 AM, Ioi Lam <ioi.lam at oracle.com> wrote:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8244775
>> http://cr.openjdk.java.net/~iklam/jdk15/8244775-remove-dependency-jfrEvents.hpp.v01/
>>
>> Currently 231 .o files depends on jfrEvents.hpp, which pulls in a lot of stuff
>> and slows down HotSpot build.
>>
>> I refactored compile.hpp, compilerEvent.hpp and g1GCPhaseTimes.hpp. Now the
>> number is down to 65 .o files.
>>
>> On my machine, debug build goes from 2m19s to 2m01s.
>>
>> Testing: passed mach5 tiers 1/2/3.
>>
>> Thanks
>> - Ioi
> GC changes look good.
>
> There are some implicit includes that might be nice to address, but those are pretty much
> pre-existing.  Consider adding utilities/ticks.hpp to g1GCParPhaseTimesTracker.hpp.
>
Hi Kim,

Thanks for the review. I've added utilities/ticks.hpp to 
g1GCParPhaseTimesTracker.hpp.

- Ioi


More information about the hotspot-gc-dev mailing list