RFR(S) 8244775 Remove unnecessary dependency to jfrEvents.hpp

Ioi Lam ioi.lam at oracle.com
Wed May 13 17:54:30 UTC 2020


Thanks Vladimir!

- Ioi

On 5/13/20 10:24 AM, Vladimir Kozlov wrote:
> Good.
>
> Thanks,
> Vladimir
>
> On 5/13/20 10:18 AM, Ioi Lam wrote:
>> Hi Vladimir,
>>
>> Thanks for your comments. I've moved the functions into compile.cpp 
>> and removed compile.inline.hpp
>>
>> http://cr.openjdk.java.net/~iklam/jdk15/8244775-remove-dependency-jfrEvents.hpp.v02/index.html 
>>
>>
>> Thanks
>> - Ioi
>>
>>
>> On 5/13/20 9:02 AM, Vladimir Kozlov wrote:
>>> Hi Ioi,
>>>
>>> This looks fine to me but why not put methods into compile.cpp 
>>> instead of .inline.hpp? It should not be performance critical.
>>>
>>> thanks,
>>> Vladimir
>>>
>>> On 5/11/20 10:36 PM, Ioi Lam wrote:
>>>> https://bugs.openjdk.java.net/browse/JDK-8244775
>>>> http://cr.openjdk.java.net/~iklam/jdk15/8244775-remove-dependency-jfrEvents.hpp.v01/ 
>>>>
>>>>
>>>> Currently 231 .o files depends on jfrEvents.hpp, which pulls in a 
>>>> lot of stuff
>>>> and slows down HotSpot build.
>>>>
>>>> I refactored compile.hpp, compilerEvent.hpp and g1GCPhaseTimes.hpp. 
>>>> Now the
>>>> number is down to 65 .o files.
>>>>
>>>> On my machine, debug build goes from 2m19s to 2m01s.
>>>>
>>>> Testing: passed mach5 tiers 1/2/3.
>>>>
>>>> Thanks
>>>> - Ioi
>>



More information about the hotspot-gc-dev mailing list