[15] RFR 8245124: Shenandoah: optimize code root evacuation/update during concurrent class unloading

Aleksey Shipilev shade at redhat.com
Mon May 18 17:54:12 UTC 2020


On 5/18/20 7:51 PM, Zhengyu Gu wrote:
> On 5/18/20 8:47 AM, Aleksey Shipilev wrote:
>> On 5/16/20 1:30 PM, Zhengyu Gu wrote:
>>> Bug:https://bugs.openjdk.java.net/browse/JDK-8245124
>>> Webrev:http://cr.openjdk.java.net/~zgu/JDK-8245124/webrev.00/
>>
>> *) Would you mind splitting out the ShenandoahNMethod::oops_do inlining?
>>
> Any reason to split? this patch is not backportable to pre-jdk14.

No reason, really. Thought it would be cleaner for backports.

> Updated: http://cr.openjdk.java.net/~zgu/JDK-8245124/webrev.01/index.html

Good. Any reason why ShenandoahEvacOOMScope is not inside heal_nmethod_metadata()? Is there any
problem to call _bs->disarm(nm) when holding that scope?

-- 
Thanks,
-Aleksey



More information about the hotspot-gc-dev mailing list