[15] RFR 8245240: Shenandoah: support nesting evacuation OOM scope

Aleksey Shipilev shade at redhat.com
Wed May 20 18:00:50 UTC 2020


On 5/20/20 5:08 PM, Zhengyu Gu wrote:
> Okay, then added assertion to make sure:
> http://cr.openjdk.java.net/~zgu/JDK-8245240/webrev.01/index.html

In push_evac_oom_scope, don't we want to assert that (level != sizeof(uint8_t)*8) or something? The
overflow there would be catastrophic, right?

Actually, now that I think of it, wouldn't it be safer to make _oom_scope_nesting_level uint32_t,
for example? That would be physically harder to overflow.

Otherwise looks fine.

-- 
Thanks,
-Aleksey



More information about the hotspot-gc-dev mailing list