[15] RFR 8245823: Shenandoah: inline/optimize ShenandoahEvacOOMScope

Zhengyu Gu zgu at redhat.com
Tue May 26 19:28:28 UTC 2020



On 5/26/20 2:00 PM, Aleksey Shipilev wrote:
> On 5/26/20 7:57 PM, Zhengyu Gu wrote:
>>> Hm! I actually thought we optimized ShenandoahHeap::heap() enough not to matter [1]. Reverting
>>> heap() cache would seem to ditch some of these overloads:
>>>
>>>    131   inline ShenandoahEvacOOMScope();
>>>    132   inline ShenandoahEvacOOMScope(Thread* t);
>>>    133   inline ShenandoahEvacOOMScope(ShenandoahHeap* heap);
>>>    134   inline ShenandoahEvacOOMScope(ShenandoahHeap* heap, Thread* t);
>>>    135   inline ~ShenandoahEvacOOMScope();
>>>
>>> Thread:current() seems fine to pass, where available, and store locally.
>>
>> Okay, updated:
>> http://cr.openjdk.java.net/~zgu/JDK-8245823/webrev.01/index.html
> 
> Looks fine to me. Roman might want to take a look.
Sure.

> 
> Nit: Excess spacing at L126 here:
> 
>   124 class ShenandoahEvacOOMScope : public StackObj {
>   125 private:
>   126   Thread* const         _thread;
>
Will fix before push.

Thanks,

-Zhengyu



More information about the hotspot-gc-dev mailing list