RFR: 8255606: Enable concurrent stack processing on x86_32 platforms [v2]

Zhengyu Gu zgu at openjdk.java.net
Tue Nov 3 13:44:15 UTC 2020


On Tue, 3 Nov 2020 12:09:36 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Zhengyu Gu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix jump direction
>
> src/hotspot/cpu/x86/x86_32.ad line 656:
> 
>> 654:   st->print_cr("POPL   EBP"); st->print("\t");
>> 655:   if (do_polling() && C->is_method_compilation()) {
>> 656:     st->print("cmpptr   rsp, poll_offset[thread]  \n\t"
> 
> Let's say `CMPL` here? I don't think we reference `cmpptr` in outputs here. Also, note every instruction is capitalized in `x86_32.ad`.

Thanks for the review.  Updated according to your suggestions.

-------------

PR: https://git.openjdk.java.net/jdk/pull/945


More information about the hotspot-gc-dev mailing list