RFR: 8252103: Parallel heap inspection for ParallelScavengeHeap [v12]

Lin Zang lzang at openjdk.java.net
Wed Nov 4 10:41:57 UTC 2020


On Wed, 4 Nov 2020 10:11:50 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Hi Albert, 
>> Thanks for suggestion and I get your point. I have a little concern with this change:  it presumes that EdenIndex and SurvivorIndex are fix to be valued as the begining of the indices (0 and 1), otherwise there are chances that youngGen may never get iterated. I am not sure whether this assumption should be kept (or at least add the info in comments?) , although the current implementation of using size_t for indices follows the assumption.
>> 
>> Thanks,
>> Lin
>
>> it presumes that EdenIndex and SurvivorIndex are fix to be valued as the begining of the indices (0 and 1)
> 
> I don't think that's problematic; the assumption, the iteration follows the order of eden, from, to, and old-gen, actually makes the code easier to read, I believe. Having said that, I have no strong opinion on this; it's up to you.

Keeping the order of iteration following eden,from,to and old-gen sounds reasonable. Thanks for explaination, will made the change in the new commit.

-------------

PR: https://git.openjdk.java.net/jdk/pull/25


More information about the hotspot-gc-dev mailing list