RFR: 8256401: ZGC: Improve ZList verification [v2]

Albert Mingkun Yang ayang at openjdk.java.net
Mon Nov 16 16:45:09 UTC 2020


On Mon, 16 Nov 2020 16:14:17 GMT, Per Liden <pliden at openjdk.org> wrote:

>> The ZList verification is currently fairly weak. I propose that we make the verification stronger to easier detect corrupt lists and misuse of list nodes. This patch also removes the unused `ZList::transfer()` function.
>
> Per Liden has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR.

Only a minor comment; the rest look fine.

src/hotspot/share/gc/z/zList.inline.hpp line 57:

> 55:   assert(_next == this, "Should not be in a list");
> 56:   assert(_prev == this, "Should not be in a list");
> 57:   verify_links();

If this node is not linked, why still "verify_links"?

-------------

Marked as reviewed by ayang (Author).

PR: https://git.openjdk.java.net/jdk/pull/1230


More information about the hotspot-gc-dev mailing list