RFR: 8256401: ZGC: Improve ZList verification [v2]

Per Liden pliden at openjdk.java.net
Mon Nov 16 19:56:00 UTC 2020


On Mon, 16 Nov 2020 16:41:49 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Per Liden has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR.
>
> src/hotspot/share/gc/z/zList.inline.hpp line 57:
> 
>> 55:   assert(_next == this, "Should not be in a list");
>> 56:   assert(_prev == this, "Should not be in a list");
>> 57:   verify_links();
> 
> If this node is not linked, why still "verify_links"?

The call to `verify_links()` is a bit superfluous here, since `_next == this && _prev == this` implies `_next->_prev == this && _prev->_next == this`. I can remove it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1230


More information about the hotspot-gc-dev mailing list