RFR: 8256813: Simplify WeakProcessor counting of OopStorage entries

Stefan Karlsson stefank at openjdk.java.net
Mon Nov 23 08:35:58 UTC 2020


On Sat, 21 Nov 2020 05:08:57 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> Please review this change to WeakProcessor's counting of weak and dead
> entries.  After JDK-8212879 we no longer need different closure classes to
> deal with the serial and oopstorage cases, since the serial case no longer
> exists.  We can collapse that down to one closure class that is tailored for
> the remaining uses.
> 
> Also deleted a stale comment left over from JDK-8212879.
> 
> Testing:
> mach5 tier1
> Locally (linux-x64) hotspot:tier1 with Serial and Parallel GCs.

Looks good, but would like to get StefanJ's question resolved.

src/hotspot/share/gc/shared/weakProcessor.hpp line 74:

> 72: 
> 73: private:
> 74:   template<typename IsAlive, typename KeepAlive> class CountingClosure;

May I suggest breaking this into two lines? It's too easy to start to read this as:
template<typename ...>
class GangTask;

-------------

Marked as reviewed by stefank (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1362


More information about the hotspot-gc-dev mailing list