RFR: 8256813: Simplify WeakProcessor counting of OopStorage entries [v2]

Kim Barrett kbarrett at openjdk.java.net
Mon Nov 23 20:19:14 UTC 2020


On Mon, 23 Nov 2020 08:26:54 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Kim Barrett has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - stefank_review
>>  - stefanj_review
>
> src/hotspot/share/gc/shared/weakProcessor.hpp line 74:
> 
>> 72: 
>> 73: private:
>> 74:   template<typename IsAlive, typename KeepAlive> class CountingClosure;
> 
> May I suggest breaking this into two lines? It's too easy to start to read this as:
> template<typename ...>
> class GangTask;

Done.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1362


More information about the hotspot-gc-dev mailing list