RFR: 8254999: Move G1RemSetSamplingTask to more appropriate location [v3]

Thomas Schatzl tschatzl at openjdk.java.net
Tue Nov 24 12:32:05 UTC 2020


On Tue, 24 Nov 2020 12:04:19 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Stefan Johansson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove new scheduling logic
>
> src/hotspot/share/gc/g1/g1RemSet.cpp line 499:
> 
>> 497: G1RemSet::~G1RemSet() {
>> 498:   delete _scan_state;
>> 499:   if (_sampling_task != NULL) {
> 
> Could you add a comment to explain when `_sampling_task` would be null?

Actually the check can be removed because the operator implementation handles NULL (by ignoring it).

-------------

PR: https://git.openjdk.java.net/jdk/pull/1395


More information about the hotspot-gc-dev mailing list