RFR: 8254999: Move G1RemSetSamplingTask to more appropriate location [v4]

Thomas Schatzl tschatzl at openjdk.java.net
Tue Nov 24 12:57:16 UTC 2020


On Tue, 24 Nov 2020 12:54:23 GMT, Stefan Johansson <sjohanss at openjdk.org> wrote:

>> Please review this change that moves the `Remembered Set Sampling Task` from `g1ServiceThread.cpp` into `g1RemSet.cpp`. This is basically just a move but with a small edition that the task will reschedule itself instead of running if at start of execution the last GC happend more recently than the value of `G1ConcRefinementServiceIntervalMillis`.
>> 
>> This change does not cover moving the timing measurements from the service thread into the task, that will be covered by: 
>> [JDK-8252645](https://bugs.openjdk.java.net/browse/JDK-8252645)
>> 
>> Testing
>> Tier1-3 + local verification that the tast is scheduled as expected.
>
> Stefan Johansson has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - Merge branch 'master' into 8254999-move-sampling-task
>  - Remove null-check before delete
>  - Remove new scheduling logic
>  - Merge branch 'master' into 8254999-move-sampling-task
>  - 8254999: Move G1RemSetSampligTask to more appropriate location

Still lgtm

-------------

Marked as reviewed by tschatzl (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1395


More information about the hotspot-gc-dev mailing list