RFR: 8255001: Move G1PeriodicGCTask to its own file [v2]

Thomas Schatzl tschatzl at openjdk.java.net
Fri Nov 27 12:38:55 UTC 2020


On Fri, 27 Nov 2020 11:59:28 GMT, Stefan Johansson <sjohanss at openjdk.org> wrote:

>> src/hotspot/share/gc/g1/g1PeriodicGCTask.hpp line 31:
>> 
>>> 29: #include "utilities/globalDefinitions.hpp"
>>> 30: #include "utilities/ticks.hpp"
>>> 31: 
>> 
>> Only the g1ServiceThread include seems to be required here. The others can be moved to the cpp file.
>
> Good catch, move the `#include "utilities/globalDefinitions.hpp"` to the cpp file, `tick.hpp` was not needed.

Lgtm.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1471


More information about the hotspot-gc-dev mailing list