RFR: 8257145: Performance regression with -XX:-ResizePLAB after JDK-8079555

Stefan Johansson sjohanss at openjdk.java.net
Fri Nov 27 15:45:57 UTC 2020


On Fri, 27 Nov 2020 12:44:54 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> I agree and noted that in the CR already. As you mention, it is still an improvement, and with `-XX:+ResizePLAB` G1 will automatically resize the PLABs back to more reasonable if needed (as G1 previously used a way too small PLAB initially).
>> 
>> Giving that typical number or threads correlate somewhat with heap size, and the policy for `-XX:+UseDynamicNumberOfThreads` is fairly conservative anyway, this change will "always" return the (correct) fixed PLAB size with `-XX:-ResizePLAB` now.
>
> I.e. if you want (and think it is a good idea), we can do both changes, first the one suggested originally, and this one so that we do not need to review + test twice.

I agree, but to be able to do both we need to store the "default size" for the `PLAB` in the `PLABStats` as well, right? What would we otherwise return in the `-ResizePLAB` case.

But storing both the default and desired size in `PLABStats` would be ok with me.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1474


More information about the hotspot-gc-dev mailing list