RFR: 8257228: G1: SIGFPE in G1ConcurrentRefine::create(int*) due to buffers_to_cards overflow [v2]

Jie Fu jiefu at openjdk.java.net
Mon Nov 30 06:54:12 UTC 2020


> Hi all,
> 
> SIGFPE was observed by running:
> java -XX:G1ConcRefinementThresholdStep=16G -XX:G1UpdateBufferSize=1G -version
> 
> The reason is that buffers_to_cards [1] returns 0 for 'step' due to overflow.
> It would be better to add overflow check logic is it.
> 
> Testing:
>   - tier1 on Linux/x64
> 
> Thanks.
> Best regards,
> Jie
> 
> [1] https://github.com/openjdk/jdk/blob/master/src/hotspot/share/gc/g1/g1ConcurrentRefine.cpp#L235

Jie Fu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:

 - Merge branch 'master' into JDK-8257228
 - Refine the erro msg
 - Fix mul-overflow-check and error reporting
 - 8257228: G1: SIGFPE in G1ConcurrentRefine::create(int*) due to buffers_to_cards overflow

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/1489/files
  - new: https://git.openjdk.java.net/jdk/pull/1489/files/6b37c517..76dec20a

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1489&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1489&range=00-01

  Stats: 5284 lines in 133 files changed: 2557 ins; 1953 del; 774 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1489.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1489/head:pull/1489

PR: https://git.openjdk.java.net/jdk/pull/1489


More information about the hotspot-gc-dev mailing list