RFR: 8269821: Remove is-queue-active check in inner loop of write_ref_array_pre_work

Thomas Schatzl tschatzl at openjdk.java.net
Fri Jul 2 15:24:02 UTC 2021


Hi all,

  can I have reviews for this small micro-optimization that removes unnecessary work in the innermost loop of  write_ref_array_pre_work()?

In particular it removes the superfluous check whether marking is active (already done at the top of the loop) and hoists out several other code that the compiler for some reason does not automatically hoist.

Testing: tier1

Thanks,
  Thomas

-------------

Commit messages:
 - Improve a bit
 - Improve write_ref_array_work

Changes: https://git.openjdk.java.net/jdk/pull/4669/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4669&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8269821
  Stats: 6 lines in 1 file changed: 4 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4669.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4669/head:pull/4669

PR: https://git.openjdk.java.net/jdk/pull/4669


More information about the hotspot-gc-dev mailing list