RFR: 8269821: Remove is-queue-active check in inner loop of write_ref_array_pre_work

Thomas Schatzl tschatzl at openjdk.java.net
Mon Jul 5 07:27:51 UTC 2021


On Fri, 2 Jul 2021 21:38:22 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Hi all,
>> 
>>   can I have reviews for this small micro-optimization that removes unnecessary work in the innermost loop of  write_ref_array_pre_work()?
>> 
>> In particular it removes the superfluous check whether marking is active (already done at the top of the loop) and hoists out several other code that the compiler for some reason does not automatically hoist.
>> 
>> Testing: tier1
>> 
>> Thanks,
>>   Thomas
>
> Looks good.

Thanks @kimbarrett @albertnetymk for your reviews.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4669


More information about the hotspot-gc-dev mailing list