RFR: 8051680: (ref) unnecessary process_soft_ref_reconsider

Kim Barrett kbarrett at openjdk.java.net
Tue Jul 6 08:21:51 UTC 2021


On Fri, 2 Jul 2021 12:59:03 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

> This PR consists of 3 commits:
> 
> 1. Removes the soft-ref reconsideration phase because the soft-ref policy is set before marking (JDK-8269596) and stays the same across the GC cycle. Reconsideration phase should not find anything interesting. That being said, there might be some benefit of using more precise heap usage after marking for soft-ref processing, created JDK-8269798 for exploring that.
> 
> 2. Removes reloading of `_soft_ref_timestamp_clock` from `java_lang_ref_SoftReference::clock();` because the master clock should only be changed by GC.
> 
> 3. Rename phase{2,3,4} to phase{1,2,3}.
> 
> Test: hotspot_gc

The first two commits look good.

As for the 3rd (phase renumbering) commit, if we're going to do all this
renaming, I'd prefer the new names were semantically meaningful, rather than
just Phase1,2,3,4.  Unfortunately that didn't happen either in or as a
followup to JDK-8202845.

-------------

Changes requested by kbarrett (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4667


More information about the hotspot-gc-dev mailing list