RFR: 8269294: Verify_before/after_young_collection should execute all verification

Kim Barrett kbarrett at openjdk.java.net
Tue Jul 6 10:00:55 UTC 2021

On Thu, 24 Jun 2021 16:12:58 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hi all,
>   can I have reviews for this tiny change that moves all verification from `do_collection_pause_at_safepoint_helper()` to `verify_before/after_young_collection`?
> I actually removed one call to `_hrm.verify_optional()` because it is already called in `_verifier->verify_region_sets_optional` although they are not completely equivalent as one call is `DEBUG_ONLY` and the other `NOT_PRODUCT`, but nobody is probably using the optimized build anyway. I can re-add the missing call if required.
> Testing: tier1
> Thanks,
>   Thomas
> P.S: this is based on PR#4539, so it would be nice if it could be reviewed before this.

Looks good.


Marked as reviewed by kbarrett (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4586

More information about the hotspot-gc-dev mailing list