RFR: 8269022: Put evacuation failure string directly into gc=info log message [v4]

Thomas Schatzl tschatzl at openjdk.java.net
Tue Jul 6 10:28:50 UTC 2021


On Mon, 5 Jul 2021 11:59:22 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Hi all,
>> 
>>   can I have reviews for this change that puts the evacuation failure marker from a separate log line into the GC timing message. I.e. instead of
>> 
>> 
>> Pause Young (Normal) (G1 Evacuation Pause)
>> To-space exhausted
>> 
>> into
>> 
>> 
>> Pause Young (Normal) (Evacuation Failure) (G1 Evacuation Pause) 
>> 
>> 
>> This is imho easier to read, better to process and less wasteful with log space.
>> 
>> Testing: tier1, gc/g1 tests
>
> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix G1AllowPreventiveGC -> G1UsePreventiveGC

I am aware of this and this has come up before. The problem is that the order of adding these strings is fixed by the execution order of the scoped objects. My initial attempt to fix this was too messy, but 'll look into this again, maybe I can find some better way.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4539


More information about the hotspot-gc-dev mailing list