RFR: 8269908: Move MemoryService::track_memory_usage call into G1MonitoringScope [v2]

Thomas Schatzl tschatzl at openjdk.java.net
Tue Jul 6 14:02:11 UTC 2021


> Hi all,
> 
>   can I have reviews for this tiny change that moves the `MemoryService::track_memory_usage()` call into the destructor of `G1MonitoringScope` so that all jstat/mxbeans related reporting is handled by that single place?
> 
> Testing: tier1-3
> 
> Thanks,
>   Thomas

Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:

  ayang review

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/4687/files
  - new: https://git.openjdk.java.net/jdk/pull/4687/files/97e18b35..a445ae33

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4687&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4687&range=00-01

  Stats: 3 lines in 1 file changed: 2 ins; 1 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4687.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4687/head:pull/4687

PR: https://git.openjdk.java.net/jdk/pull/4687


More information about the hotspot-gc-dev mailing list