RFR: 8269022: Put evacuation failure string directly into gc=info log message [v5]

Kim Barrett kbarrett at openjdk.java.net
Tue Jul 6 22:11:55 UTC 2021


On Tue, 6 Jul 2021 11:00:22 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Hi all,
>> 
>>   can I have reviews for this change that puts the evacuation failure marker from a separate log line into the GC timing message. I.e. instead of
>> 
>> 
>> Pause Young (Normal) (G1 Evacuation Pause)
>> To-space exhausted
>> 
>> into
>> 
>> 
>> Pause Young (Normal) (Evacuation Failure) (G1 Evacuation Pause) 
>> 
>> 
>> This is imho easier to read, better to process and less wasteful with log space.
>> 
>> Testing: tier1, gc/g1 tests
>
> Thomas Schatzl has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
> 
>  - Reorder messages in string to be more natural
>  - Merge branch 'master' of gh:tschatzl/jdk into 8269022-evac-failure-string-in-gc-info-message
>  - Fix G1AllowPreventiveGC -> G1UsePreventiveGC
>  - lkorinth review - forgot to save comment update
>  - lkorinth review
>  - Initial implementation

Looks good.

I agreed with Albert's comment about the order of the annotations.  I'm glad you found a (nice, not kludgy) way to fix that.

-------------

Marked as reviewed by kbarrett (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4539


More information about the hotspot-gc-dev mailing list