RFR: 8269022: Put evacuation failure string directly into gc=info log message [v4]

Thomas Schatzl tschatzl at openjdk.java.net
Wed Jul 7 07:36:57 UTC 2021


On Tue, 6 Jul 2021 10:17:44 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix G1AllowPreventiveGC -> G1UsePreventiveGC
>
> Regarding `Pause Young (Normal) (Evacuation Failure) (G1 Evacuation Pause)`, I interpret the three pairs of parens as:
> 
> 
> 1. (<gc pause kind, deciding what should be done in this pause>)
> 2. (<sth unexpected happened, deviating from the original plan>)
> 3. (<what initiates this pause>)
> 
> 2 occurs strictly later than 1&3, so a more natural order is
> 
> `Pause Young (Normal) (G1 Evacuation Pause) (Evacuation Failure)`.
> 
> This way, the original structure (meaning of the first two pairs of parens) could be preserved in all cases. When sth unexpected happens, the log is only appended, leaving the "conceptually existing" part intact.
> 
> Ofc, this is very subjective; just my 2 cents. (Merely a comment, not a review. I am fine with the current change.)

Thanks @albertnetymk @walulyai @lkorinth @kimbarrett for your reviews.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4539


More information about the hotspot-gc-dev mailing list