RFR: 8269294: Verify_before/after_young_collection should execute all verification

openjdk-notifier [bot] "github.com+73116608+openjdk-notifier[bot]" at openjdk.java.net
Wed Jul 7 07:40:20 UTC 2021


On Thu, 24 Jun 2021 16:12:58 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hi all,
> 
>   can I have reviews for this tiny change that moves all verification from `do_collection_pause_at_safepoint_helper()` to `verify_before/after_young_collection`?
> 
> I actually removed one call to `_hrm.verify_optional()` because it is already called in `_verifier->verify_region_sets_optional` although they are not completely equivalent as one call is `DEBUG_ONLY` and the other `NOT_PRODUCT`, but nobody is probably using the optimized build anyway. I can re-add the missing call if required.
> 
> Testing: tier1
> 
> Thanks,
>   Thomas
> 
> P.S: this is based on PR#4539, so it would be nice if it could be reviewed before this.

The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:


git checkout submit/8269022-evac-failure-string-in-gc-info-message
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

-------------

PR: https://git.openjdk.java.net/jdk/pull/4586


More information about the hotspot-gc-dev mailing list