Integrated: 8269294: Verify_before/after_young_collection should execute all verification

Thomas Schatzl tschatzl at openjdk.java.net
Wed Jul 7 08:01:22 UTC 2021


On Thu, 24 Jun 2021 16:12:58 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hi all,
> 
>   can I have reviews for this tiny change that moves all verification from `do_collection_pause_at_safepoint_helper()` to `verify_before/after_young_collection`?
> 
> I actually removed one call to `_hrm.verify_optional()` because it is already called in `_verifier->verify_region_sets_optional` although they are not completely equivalent as one call is `DEBUG_ONLY` and the other `NOT_PRODUCT`, but nobody is probably using the optimized build anyway. I can re-add the missing call if required.
> 
> Testing: tier1
> 
> Thanks,
>   Thomas
> 
> P.S: this is based on PR#4539, so it would be nice if it could be reviewed before this.

This pull request has now been integrated.

Changeset: 248aa501
Author:    Thomas Schatzl <tschatzl at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/248aa5014b6fc5ef4d3de1feca62aa82ed55b8ba
Stats:     9 lines in 1 file changed: 3 ins; 6 del; 0 mod

8269294: Verify_before/after_young_collection should execute all verification

Reviewed-by: iwalulya, kbarrett

-------------

PR: https://git.openjdk.java.net/jdk/pull/4586


More information about the hotspot-gc-dev mailing list