RFR: 8269914: Factor out heap printing for G1 young and full gc [v2]

Thomas Schatzl tschatzl at openjdk.java.net
Thu Jul 8 12:01:54 UTC 2021


On Thu, 8 Jul 2021 11:32:55 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Thomas Schatzl has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR.
>
> src/hotspot/share/gc/g1/g1CollectedHeap.cpp line 2948:
> 
>> 2946:   _g1h->print_heap_after_gc();
>> 2947:   // We are at the end of the GC. Total collections has already been increased.
>> 2948:   _g1h->rem_set()->print_periodic_summary_info("After GC RS summary", _g1h->total_collections() - 1);
> 
> It's unclear to me why they are separated into two sections here. Additionally, does the order matter? If not, is it possible to group the two `rem_set()` calls together?

One is printing about the heap, other is printing "other" stuff.

> src/hotspot/share/gc/g1/g1CollectedHeap.cpp line 2981:
> 
>> 2979:   void report_pause_type(G1GCPauseType type) {
>> 2980:     tracer()->report_young_gc_pause(type);
>> 2981:   }
> 
> This one seems unused.

Fixed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4705


More information about the hotspot-gc-dev mailing list