RFR: 8269914: Factor out heap printing for G1 young and full gc [v2]

Thomas Schatzl tschatzl at openjdk.java.net
Thu Jul 8 12:05:55 UTC 2021


On Thu, 8 Jul 2021 11:41:33 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Thomas Schatzl has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR.
>
> src/hotspot/share/gc/g1/g1CollectedHeap.cpp line 3070:
> 
>> 3068:         _allocator->release_mutator_alloc_regions();
>> 3069: 
>> 3070:         calculate_collection_set(*jtm.evacuation_info(), target_pause_time_ms);
> 
> `*jtm.evacuation_info()` seems odd; `calculate_collection_set` could use pointer instead of reference, right?

It has been there that way, so I kept it in that change. Now changed all uses to pointers.

> src/hotspot/share/gc/g1/g1FullGCScope.hpp line 71:
> 
>> 69:                 bool clear_soft,
>> 70:                 bool do_maximal_compaction);
>> 71:   ~G1FullGCScope() { }
> 
> Why not just remove this destructor?

Forgotten.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4705


More information about the hotspot-gc-dev mailing list