Integrated: 8269914: Factor out heap printing for G1 young and full gc

Thomas Schatzl tschatzl at openjdk.java.net
Fri Jul 9 06:54:57 UTC 2021


On Wed, 7 Jul 2021 08:23:35 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hi all,
> 
> can I have reviews for this change that factors out before/after heap related printing into a single scoped object to be used for both young and full gc code?
> 
> There is some minor change in order of printing of unrelated log output (COMMIT/UNCOMMIT region state changes vs. other heap printing), during full gc but since this is very low level debugging I do not see a problem to do that.
> 
> (Sorry for the trouble with open/closing this issue already: have been experimenting with the feature to base PRs on other PRs which kind-of failed a bit; rebased on tip after being able to push all dependencies, so this one should be good)
> 
> To keep JFR event sending in the correct order, this change includes JDK-8270018.
> 
> Thanks,
>   Thomas

This pull request has now been integrated.

Changeset: c93204ce
Author:    Thomas Schatzl <tschatzl at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/c93204ce3d4653705e6aeeadb9b3c591e469de77
Stats:     199 lines in 7 files changed: 107 ins; 62 del; 30 mod

8269914: Factor out heap printing for G1 young and full gc
8270018: Add scoped object for g1 young gc JFR notification

Reviewed-by: ayang, iwalulya, kbarrett

-------------

PR: https://git.openjdk.java.net/jdk/pull/4705


More information about the hotspot-gc-dev mailing list