RFR: 8051680: (ref) unnecessary process_soft_ref_reconsider [v2]

Kim Barrett kbarrett at openjdk.java.net
Fri Jul 9 20:27:50 UTC 2021

On Fri, 9 Jul 2021 08:08:19 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> This PR consists of 3 commits:
>> 1. Removes the soft-ref reconsideration phase because the soft-ref policy is set before marking (JDK-8269596) and stays the same across the GC cycle. Reconsideration phase should not find anything interesting. That being said, there might be some benefit of using more precise heap usage after marking for soft-ref processing, created JDK-8269798 for exploring that.
>> 2. Removes reloading of `_soft_ref_timestamp_clock` from `java_lang_ref_SoftReference::clock();` because the master clock should only be changed by GC.
>> 3. Rename phase{2,3,4} to phase{1,2,3}.
>> Test: hotspot_gc
> Albert Mingkun Yang has updated the pull request incrementally with one additional commit since the last revision:
>   Revert "rename"
>   This reverts commit 740e18530eae4be0824398c156ae4ce3634b4e1e.

Looks good.


Marked as reviewed by kbarrett (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4667

More information about the hotspot-gc-dev mailing list