RFR: 8269295: Verification time before/after young collection only covers parts of the verification

Thomas Schatzl tschatzl at openjdk.java.net
Mon Jul 12 08:43:58 UTC 2021


On Mon, 12 Jul 2021 07:37:43 GMT, Ivan Walulya <iwalulya at openjdk.org> wrote:

>> Hello,
>> 
>>   another mess-up of mine related to dependent merge-requests: after trying to integrate I assumed everything was fine but the bot did not agree - after the push of the base change there were merge errors. I did not notice that and just deleted the branch.
>> Then I tried to resurrect it, but it did not work, after the manual merge there were tons of changes. Since I'm too afraid to mess something up, I just made a new PR. Apologies for all the reviewers to be required to look at this again. :(
>> It looks like I'm now "healed" from dependent PRs...
>> 
>> Nothing changed, really - here's the original PR request text:
>> 
>> can I have reviews for this change that makes "Verify Before/After GC" contain all young collection time instead only a (large) part.
>> 
>> This change also removed some unnecessary and unused return values. They can certainly be re-added if necessary.
>> 
>> Testing: tier1
>> 
>> Thanks,
>>   Thomas
>
> lgtm!

Thanks @walulyai @kimbarrett for your reviews.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4745


More information about the hotspot-gc-dev mailing list