RFR: 8270282: Semantically rename reference processing subphases

Kim Barrett kbarrett at openjdk.java.net
Mon Jul 12 12:20:57 UTC 2021


On Mon, 12 Jul 2021 10:24:32 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

> Simple rename of phase{2,3,4} to something with semantic meaning.

Mostly looks good, except for a naming choice.

src/hotspot/share/gc/shared/referenceProcessorPhaseTimes.hpp line 83:

> 81:   ~ReferenceProcessorPhaseTimes();
> 82: 
> 83:   WorkerDataArray<double>* SoftWeakFinalRefsPhase_worker_time_sec() const { return _SoftWeakFinalRefsPhase_worker_time_sec; }

This is a weird function name.  I understand why, but I'm not convinced.  We have process_soft_weak_final_refs and the like, for example.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4752


More information about the hotspot-gc-dev mailing list