[jdk17] RFR: 8269240: java/foreign/stackwalk/TestAsyncStackWalk.java test failed with concurrent GC [v2]

Vladimir Ivanov vlivanov at openjdk.java.net
Tue Jul 13 17:09:12 UTC 2021


On Tue, 13 Jul 2021 14:59:07 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> src/hotspot/share/runtime/thread.hpp line 1128:
>> 
>>> 1126: 
>>> 1127:  private:
>>> 1128:   DEBUG_ONLY(void verify_frame_info();)
>> 
>> If you declare `verify_frame_info` as returning a `bool` (and just put a `return true;` at the end of `JavaThread::verify_frame_info()`), you can call it as:
>> 
>> assert(verify_frame_info(), "unexpected frame info");
>
> Thanks for the suggestion. I'd like to keep it the way it is though, so that the assert message contains the `has_last_frame` & `java_call_counter` values. (this was one of the reason I did this refactor as well, since the assert I was hitting out of those 3 didn't contain that info).

You can keep the assert inside `verify_frame_info()` which dumps additional data. (Yes, it's a bit confusing: assert inside an assert :-) )

-------------

PR: https://git.openjdk.java.net/jdk17/pull/149


More information about the hotspot-gc-dev mailing list