RFR: 8270014: Add scoped objects for g1 young gc verification and young gc internal timing [v2]

Thomas Schatzl tschatzl at openjdk.java.net
Wed Jul 14 07:48:13 UTC 2021


On Wed, 14 Jul 2021 07:39:31 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> src/hotspot/share/gc/g1/g1Policy.hpp line 305:
>> 
>>> 303: 
>>> 304:   void note_young_gc_pause_start();
>>> 305:   void note_young_gc_pause_end();
>> 
>> It's not obvious to me if there's a diff btw `young_gc_pause` and  `young_collection`, or what the diff is. I think having some comments for these two pairs of methods would make it easier to understand.
>
> Added comments. `gc_pause` is the whole pause, `collection` is about just the collection part (as defined by the inner scope of the `do_collection_pause_at_safepoint_helper`). Feel free to suggest better naming.

Maybe something like `record_young_collection_work_start`; another question is whether we should keep the `note_` prefix for the pause or change it to `record_` as well as it seems quite common.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4768


More information about the hotspot-gc-dev mailing list