RFR: 8270014: Add scoped objects for g1 young gc verification and young gc internal timing [v4]
kbarrett at openjdk.java.net
Thu Jul 15 07:19:16 UTC 2021
On Wed, 14 Jul 2021 09:08:38 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
>> Hi all,
>> can I get reviews for some further cleanup of the young collection code:
>> - adding some more scoped objects (verification, gc pause timing)
>> - some naming, minor related code movement
> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
> Change note_ to record_
Changes requested by kbarrett (Reviewer).
src/hotspot/share/gc/g1/g1Policy.cpp line 635:
> 633: G1GCPhaseTimes* p = phase_times();
> 635: double start_time_s = phase_times()->cur_collection_start_sec();
I dislike this change of nomenclature to use `_s` suffix instead of `_sec` suffix to indicate units of seconds. The latter is in wide use in GC code.
More information about the hotspot-gc-dev