RFR: 8264908: Investigate adding BOT range check in G1BlockOffsetTablePart::block_at_or_preceding

Ivan Walulya iwalulya at openjdk.java.net
Thu Jul 15 08:53:15 UTC 2021


On Wed, 14 Jul 2021 12:27:08 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Hi all,
>> 
>> Please review this cleanup change to add an assert to G1BlockOffsetTablePart::block_at_or_preceding. Additionally, remove code that attempts to read beyond the _next_offset_index threshold. 
>> 
>> Testing: Tier 1-3
>
> Re `if (addr >= _hr->bottom() && addr < _hr->top()) {`, I don't think we ever pass `addr` outside `[bottom, top)`, so I suggest restore the original code and change this to an assert in another PR.

Thanks @albertnetymk and @tschatzl for the reviews!

-------------

PR: https://git.openjdk.java.net/jdk/pull/4775


More information about the hotspot-gc-dev mailing list