[jdk17] RFR: 8269240: java/foreign/stackwalk/TestAsyncStackWalk.java test failed with concurrent GC [v3]

Jorn Vernee jvernee at openjdk.java.net
Fri Jul 16 11:55:57 UTC 2021


On Fri, 16 Jul 2021 02:12:20 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address David's review comments
>
> src/hotspot/share/prims/universalUpcallHandler.cpp line 62:
> 
>> 60:     guarantee(result == JNI_OK, "Could not attach thread for upcall. JNI error code: %d", result);
>> 61:     *should_detach = true;
>> 62:     thread = Thread::current();
> 
> You could use JavaThread::current() here and avoid the later conversions.

Ok. The variable is initially initialized (hah) using `Thread::current_or_null()` and there was no equivalent that does that for `JavaThread`. I can add something like that though.

-------------

PR: https://git.openjdk.java.net/jdk17/pull/149


More information about the hotspot-gc-dev mailing list