RFR: 8270961: [TESTBUG] Move GotWrongOOMEException into vm.share.gc package [v2]

Leonid Mesnik lmesnik at openjdk.java.net
Thu Jul 22 04:41:25 UTC 2021


On Thu, 22 Jul 2021 04:13:16 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Leonid Mesnik has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>> 
>>  - fixed after Kim's comments.
>>  - Merge branch 'master' of https://github.com/openjdk/jdk into 8270961
>>  - fixed log string.
>>  - import fix.
>>  - 8270961
>
> test/hotspot/jtreg/vmTestbase/metaspace/stressHierarchy/common/StressHierarchyBaseClass.java line 117:
> 
>> 115:              * We pass test in this case as this breaks test logic. We have dedicated test configurations
>> 116:              * for OOME:heap provoking class unloading, that why we are not missing test coverage here.
>> 117:              */
> 
> This comment is unnecessary, as it adds nothing over the log message that follows.

Thanks! I just moved it and missed that is the same as the log message.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4844


More information about the hotspot-gc-dev mailing list