RFR: 8271060: Merge G1CollectedHeap::determine_start_concurrent_mark_gc and G1Policy::decide_on_conc_mark_initiation [v2]
kbarrett at openjdk.java.net
Thu Jul 22 13:39:48 UTC 2021
On Thu, 22 Jul 2021 10:48:16 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
>> Hi all,
>> can I have reviews for this merge of two methods that have the same purpose: determine whether this pause should be a concurrent start pause. The reason for this merge is that `G1CollectedHeap::determine_start_concurrent_mark_gc` just calls the other, and
>> - is the only caller
>> - only adds another condition of the same type that `G1Policy::decide_on_conc_mark_initiation` does at the beginning
>> - adds some return value checking and return value
>> which all imho fit into `G1Policy::decide_on_conc_mark_initiation` too.
>> It also reduces `G1CollectedHeap` a bit. The main reason for me to put this in the new location is basically that that additional condition in `G1CollectedHeap::determine_start_concurrent_mark_gc` makes all conditions for that decision be located closer together.
>> If you think otherwise and this is a bad idea, I will close this PR.
>> Testing: manual gc/g1 runs
> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
> ayang review
Marked as reviewed by kbarrett (Reviewer).
More information about the hotspot-gc-dev