RFR: 8270912: Clean up G1CollectedHeap::process_discovered_references()

Kim Barrett kbarrett at openjdk.java.net
Thu Jul 22 13:49:50 UTC 2021


On Wed, 21 Jul 2021 10:14:58 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hi all,
> 
>   can I have reviews for this cleanup of `G1CollectedHeap::process_discovered_references()`, cleaning out obsolete or duplicate code and moving asserts?
> 
> Testing: tier1-5
> 
> Thanks,
>   Thomas

One suggestion for a minor improvement.  Otherwise looks good.

src/hotspot/share/gc/g1/g1CollectedHeap.cpp line 3282:

> 3280:     G1STWIsAliveClosure is_alive(&_g1h);
> 3281:     G1CopyingKeepAliveClosure keep_alive(&_g1h, _pss.state_for_worker(index));
> 3282:     G1ParEvacuateFollowersClosure complete_gc(&_g1h, _pss.state_for_worker(index), &_task_queues, _tm == RefProcThreadModel::Single ? nullptr : &_terminator, G1GCPhaseTimes::ObjCopy);

New `pss` variable could be used in these two statements too.

-------------

Marked as reviewed by kbarrett (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4857


More information about the hotspot-gc-dev mailing list