RFR: 8270870: Simplify G1ServiceThread

Kim Barrett kbarrett at openjdk.java.net
Fri Jul 23 11:42:11 UTC 2021


On Thu, 22 Jul 2021 13:03:49 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Please review this simplification of the internal control structure of
>> G1ServiceThread, particularly around the entry and exit of monitor contexts.
>> 
>> In addition, the run_task logging now includes the delay between the
>> scheduled time to run and the actual, as that seems like useful information
>> to have sometimes.
>> 
>> I also changed the monitor rank from nonleaf to leaf.  There was no reason
>> to use nonleaf, and leaf avoids questions about why nonleaf was used.
>> 
>> Testing:
>> mach5 tier1-3.  This includes the gtest for G1ServiceThread.
>> 
>> Ran a test program with gc+task logging enabled and checked that the logging
>> output looked okay.
>
> Lgtm.

Thanks @tschatzl and @walulyai  for reviews.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4868


More information about the hotspot-gc-dev mailing list