RFR: 8193559: ugly DO_JAVA_THREADS macro should be replaced [v5]

Kim Barrett kbarrett at openjdk.java.net
Sat Jul 31 04:37:31 UTC 2021


On Fri, 30 Jul 2021 20:53:53 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> This is a simple rewrite of what is "Possibly the ugliest for loop the world has seen."
>> Thanks to @stefank for the draft proposed fix. Thanks to @fisk for providing this
>> piece of history that I'm finally getting around to cleaning up. While this macro has
>> been with us for a long time, its time has passed...
>> 
>> Tested with Mach5 Tier[1-3].
>
> Daniel D. Daugherty has updated the pull request incrementally with one additional commit since the last revision:
> 
>   kbarrett CR - simplify 'ThreadsList::Iterator::operator!=(Iterator i)'

This looks good to me (unsurprisingly), except for the prefetch question.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4671


More information about the hotspot-gc-dev mailing list