RFR: 8267937: Wrong indentation in G1 gc+phases log for free cset subphases

Stefan Johansson sjohanss at openjdk.java.net
Tue Jun 1 09:56:19 UTC 2021


On Fri, 28 May 2021 13:59:37 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hi all,
> 
>   JDK-8214327: Join parallel phases post evacuation messed up some indentation of logging:
>   
> The current gc+phases=trace looks as follows:
>  ```
> [0.059s][debug][gc,phases   ] GC(1)       Redirty Logged Cards (ms):     Min:  0.0, Avg:  0.0, Max:  0.0, Diff:  0.0, Sum:  0.0, Workers: 3
> [0.059s][debug][gc,phases   ] GC(1)         Redirtied Cards:               Min: 0, Avg: 184.3, Max: 531, Diff: 531, Sum: 553, Workers: 3
> [0.059s][debug][gc,phases   ] GC(1)       Free Collection Set (ms):      Min:  0.0, Avg:  0.0, Max:  0.0, Diff:  0.0, Sum:  0.0, Workers: 3
> [0.059s][trace][gc,phases   ] GC(1)           Young Free Collection Set (ms): Min:  0.0, Avg:  0.0, Max:  0.0, Diff:  0.0, Sum:  0.0, Workers: 1
> [0.059s][trace][gc,phases   ] GC(1)           Non-Young Free Collection Set (ms): skipped
> 
> `Young Free Collection Set` and `Non-Young Free Collection set` are indented one level too many.
> 
> This change fixes this.
> 
> Testing: manual testing, there is no indentation check for log messages
> 
> Thanks,
>   Thomas

Looks good.

-------------

Marked as reviewed by sjohanss (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4249


More information about the hotspot-gc-dev mailing list