RFR: 8267703: runtime/cds/appcds/cacheObject/HeapFragmentationTest.java crashed with OutOfMemory [v2]

Stefan Johansson sjohanss at openjdk.java.net
Tue Jun 1 15:17:21 UTC 2021


On Tue, 1 Jun 2021 13:11:55 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Stefan Johansson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revised approach.
>
> src/hotspot/share/gc/g1/g1FullCollector.cpp line 98:
> 
>> 96: 
>> 97:   // Finally consider the amount of used regions.
>> 98:   uint used_worker_limit = MAX2(heap->num_used_regions(), 1u);
> 
> Should we actually end up here with zero used regions? It does not hurt, but seems superfluous

No we should not, but I went with the super-safe option and added the `MAX2(...)`. If you like, I can remove it :)

-------------

PR: https://git.openjdk.java.net/jdk/pull/4225


More information about the hotspot-gc-dev mailing list