RFR: 8267875: Shenandoah: Duplicated code in ShenandoahBarrierSetC2::ideal_node()

Roland Westrelin roland at openjdk.java.net
Mon Jun 7 13:48:20 UTC 2021


On Thu, 27 May 2021 18:29:40 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:

> Node::set_req_X definition as:
> void Node::set_req_X(uint i, Node *n, PhaseGVN *gvn) {
>   PhaseIterGVN* igvn = gvn->is_IterGVN();
>   if (igvn == NULL) {
>     set_req(i, n);
>     return;
>   }
>   set_req_X(i, n, igvn);
> }
> 
> ShenandoahBarrierSetC2::ideal_node() duplicates above logic.
> 
> 
> Test:
>   hotspot_gc_shenandoah

Looks good to me.

-------------

Marked as reviewed by roland (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4229


More information about the hotspot-gc-dev mailing list