RFR: 8268647: Generation::expand_and_allocate has unused "parallel" argument

Thomas Schatzl tschatzl at openjdk.java.net
Mon Jun 14 15:22:52 UTC 2021


On Mon, 14 Jun 2021 14:36:15 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> Please review this simplification of the Generation class and the classes
> derived from it.  There are no callers of expand_and_allocate that pass the
> third argument explicitly, so its value is always the default (false) value.
> 
> This change removes the argument and updates the two implementations of this
> virtual function accordingly.
> 
> [The "parallel" argument is probably a leftover from CMS support.]
> 
> Testing:
> mach5 tier1.

Lgtm. I suggested a small whitespace change.

src/hotspot/share/gc/serial/defNewGeneration.cpp line 498:

> 496: }
> 497: 
> 498: HeapWord* DefNewGeneration::expand_and_allocate(size_t size, bool   is_tlab) {

Suggestion:

HeapWord* DefNewGeneration::expand_and_allocate(size_t size, bool is_tlab) {

-------------

Marked as reviewed by tschatzl (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4485


More information about the hotspot-gc-dev mailing list