[jdk17] RFR: 8267271: Fix gc/arguments/TestNewRatioFlag.java expectedNewSize calculation

Thomas Schatzl tschatzl at openjdk.java.net
Tue Jun 15 08:05:41 UTC 2021


On Fri, 11 Jun 2021 13:47:49 GMT, Stefan Johansson <sjohanss at openjdk.org> wrote:

> Please review this test-fix to avoid failures on certain platforms.
> 
> **Summary**
> Fixes an incorrect calculation in the test when trying to predict the new size given the `NewRatio`. The fix is not strictly bound to different platforms but to the resulting heap-size the test is run with. Both with Serial and Parallel the test fails if run on a platform using a heap alignment that forces the heap to be 104 MB instead of the specified 100 MB. It is a bit unclear why the test even passes with 100MB, since the calculation done in the test doesn't match the calculation done in the JVM. 
> 
> **Testing**
> Manual testing to verify the fix actually fixes the issue and works with multiple page sizes. Mach5 testing on affected platforms to verify the fix is good there as well.

Lgtm. Took a while to find the corresponding code in the VM :)

-------------

Marked as reviewed by tschatzl (Reviewer).

PR: https://git.openjdk.java.net/jdk17/pull/28


More information about the hotspot-gc-dev mailing list